plugins: avoid circular dependencies #332
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kenyon
force-pushed
the
fix-circular-dependencies
branch
from
ed36053
to
af10959
Compare
|
It looks like there is an ordering problem that needs to be fixed. |
bastelfreak
approved these changes
Nov 6, 2023
|
@bastelfreak this isn't ready due to the test failures, but I don't use this module on EL, so someone else might want to figure out what needs to be done before I get around to it. |
`include` the letsencrypt class instead of `require` it. Fixes voxpupuli#331.
kenyon
force-pushed
the
fix-circular-dependencies
branch
from
af10959
to
dad2606
Compare
bastelfreak
approved these changes
Nov 26, 2023
This was referenced Nov 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
includethe letsencrypt class instead ofrequireit.Fixes #331.